chore(ecmascript)!: switch to ES2024 #2505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
ferferga
force-pushed
the
es2024
branch
2 times, most recently
from
d7fd08c to
13c5a62
Compare
|
Something I've been forgetting to update is the browserslist query. However, there's no possibility to query by ECMAScript version: browserslist/browserslist#795 TODO: Investigate with CanIUse or browserslist themselves in a way to support querying for specific ecma versions, since it would be much easier and maintenable to do it that way. |
ferferga
changed the title
ferferga
force-pushed
the
es2024
branch
2 times, most recently
from
23221f8 to
7324af4
Compare
ferferga
force-pushed
the
master
branch
3 times, most recently
from
f9af7d1 to
b898fd1
Compare
For some reason, the client throwed an error about incorrect attribute when using Docker buildx's docker-container driver. The build worked flawlessly when using the normal docker build command (which is now an alias to docker buildx build, but with the docker driver) and in the host system using normal commands, and that's why it went unnoticed. Really strange error... Perhaps something encoding related in the outputted files? Either way, this commit fixes it by removing the trailing double quotes from the component!
|
ferferga
force-pushed
the
master
branch
5 times, most recently
from
da410ff to
9a9eeae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ECMAScript upgrade is needed for
Object.groupBy, which we use across the codebaseThis can't be merged until TypeScript 5.7 has ubiquituous support by
VSCode,ESLintandvue-tsc